docs: annotate with @Override #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses: /uPortal/uPortal-portlets/src/main/java/org/apereo/portal/portlets/statistics/TabRenderStatisticsController.java:159: warning: [MissingOverride] createColumnDiscriminatorMap implements method in BaseStatisticsReportController; expected @OverRide createColumnDiscriminatorMap(TabRenderReportForm form) { ^ (see http://errorprone.info/bugpattern/MissingOverride)
Addresses /uPortal/uPortal-portlets/src/main/java/org/apereo/portal/portlets/statistics/BasePortletLayoutStatisticsController.java:134: warning: [MissingOverride] createColumnDiscriminatorMap implements method in BaseStatisticsReportController; expected @OverRide createColumnDiscriminatorMap(F form) { ^ (see http://errorprone.info/bugpattern/MissingOverride)
Addresses /uPortal/uPortal-layout/uPortal-layout-impl/src/main/java/org/apereo/portal/layout/dlm/Precedence.java:33: warning: [MissingOverride] toString overrides method in Object; expected @OverRide public String toString() { ^ (see http://errorprone.info/bugpattern/MissingOverride)
Addresses /uPortal/uPortal-layout/uPortal-layout-impl/src/main/java/org/apereo/portal/layout/dlm/MissingPortletDefinition.java:323: warning: [MissingOverride] setDescription implements method in IPortletType; expected @OverRide public void setDescription(String descr) {} ^ (see http://errorprone.info/bugpattern/MissingOverride)
Addresses /uPortal/uPortal-layout/uPortal-layout-impl/src/main/java/org/apereo/portal/layout/dlm/MissingPortletDefinition.java:222: warning: [MissingOverride] setType implements method in IPortletDefinition; expected @OverRide public void setType(IPortletType channelType) {} ^ (see http://errorprone.info/bugpattern/MissingOverride)
addresses /uPortal/uPortal-layout/uPortal-layout-impl/src/main/java/org/apereo/portal/layout/dlm/LPAResetParameter.java:43: warning: [MissingOverride] perform implements method in ILayoutProcessingAction; expected @OverRide public void perform() throws PortalException { ^ (see http://errorprone.info/bugpattern/MissingOverride)
apetro
changed the title
ChristianMurphy
approved these changes
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build logs have a bunch of
warning: [MissingOverride]noise. Add the suggested@Overrideannotations and thereby reduce the noise.Checklist
@Override