Refactoring and cleaning on SmartLDAPGroupStore #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgribonvald
changed the title
ChristianMurphy
approved these changes
May 22, 2018
|
Sorry I've found a problem on moving the SmartLDAPGroupStore bean to an other file/path, the placeholder can't find properties... I'm watching why ! |
…edList to out-perform ArrayList or ArrayDeque.
|
So this time it's OK with some commits more for the cleaning of depreciated code. |
ChristianMurphy
approved these changes
May 29, 2018
|
@ChristianMurphy Thx ! Now I have to work on some improvment on this groupStore and to provide test cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Only few Changes: