fix: update the PortletsRESTController.getRenderedPortlet method (AP… #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RequestMapping '/v4-3/portlet/{fname}.html') so that it prepares the PortalHttpServletRequestWrapper and PortalHttpServletResponseWrapper in the same way that UrlCanonicalizingFilter does (for typical portal requests)
ChristianMurphy
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…I @RequestMapping '/v4-3/portlet/{fname}.html') so that it prepares the PortalHttpServletRequestWrapper and PortalHttpServletResponseWrapper in the same way that UrlCanonicalizingFilter does (for typical portal requests)
Checklist
Description of change
This change fixes an issue with the
/v4-3/portlet/{fname}.htmlAPI endpoint where some portlets would fail to render becausePortalHttpServletRequestWrapperandPortalHttpServletResponseWrapperobjects were not set up (and passed downstream to the rest of the portal) in the manner thatUrlCanonicalizingFilterdoes it.This change also refactors creating and properly initializing instances of these wrapper classes to a new
@Servicebean --PortalHttpServletFactoryService-- so thatUrlCanonicalizingFilterandPortletsRESTControllercan leverage the same code (DRY principal).