fix: Accessibility issue #1509
Merged
fix: Accessibility issue #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propose to fix issue uPortal-Project#1353
ChristianMurphy
approved these changes
Jan 30, 2019
There was a problem hiding this comment.
Thanks @GuillaumeRozier! 🙇♂️
Welcome to the uPortal community! 👋
These changes look good to me. 👍
ChristianMurphy
added
enhancement
cousquer
approved these changes
Jan 30, 2019
There was a problem hiding this comment.
LGTM! 👍 fully respect two rules of WAI-ARIA:
- first rule is: if you don't need ARIA, Don't use it
- second rule is: "if it goes somewhere, use a link
<a href="#somewhere>, if it does something, use a button<button >
Enjoying asynchronously a beer 🍻 with you @GuillaumeRozier
Many thanks! 😉
|
Thank you @GuillaumeRozier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose to fix issue #1353
Checklist
Description of change
Removed
role="button"from https://github.com/Jasig/uPortal/blob/master/uPortal-webapp/src/main/resources/layout/theme/respondr/navigation.xsl#L375Tested with VoiceOver.