#1526 Added the type param to the Search REST API #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cbeach47 it looks like CI is requesting code style changes. git pull upstream master --rebase
./gradlew goJF
git add --all
git commit |
ChristianMurphy
approved these changes
Feb 26, 2019
...i/uPortal-api-rest/src/test/java/org/apereo/portal/rest/search/SearchRESTControllerTest.java
Show resolved
Hide resolved
drewwills
reviewed
Feb 26, 2019
| HttpServletRequest request, | ||
| HttpServletResponse response) | ||
| throws IOException { | ||
|
|
||
| final Map<String, List<?>> searchResults = new TreeMap<>(); | ||
| if (logger.isDebugEnabled()) { | ||
| logger.debug( | ||
| "Searching with q={}, type={}", query, ArrayUtils.toString(types.toArray())); |
There was a problem hiding this comment.
At least some of this logging code is unnecessary. I think the following will work nicely...
logger.debug("Searching with q={}, type={}", query, types);
Without trying it, I'm not sure if the ArrayUtils.toString(types.toArray()) part is necessary.
There was a problem hiding this comment.
Update...
DEBUG [http-nio-8080-exec-2-admin] o.a.p.r.search.SearchRESTController 2019-02-26 16:18:30,738 - Searching with q=student, type=[people, portlets]
DEBUG [http-nio-8080-exec-9-admin] o.a.p.r.search.SearchRESTController 2019-02-26 16:18:44,240 - Searching with q=student, type=[portlets]
|
Tested locally -- works well. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1526.
Checklist
Description of change
/api/v5-0/portal/searchcan now take an optionaltypeparameter that can be a multi-value parameter.