Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/upse-311: Create API to support scheduling portlet maintenance mode #2626

Merged
merged 19 commits into from Jan 27, 2023

Conversation

mgillian
Copy link
Contributor

Checklist
Description of change

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mgillian!

Documentation could be valuable here.
I gather from skimming the code this is a new type of scheduled maintenance mode for portlets?

Is there associated documentation planned?
Either for the markdown files in this project, the docs in uportal start, or the WIP uPortal website?

Any testing notes folks should be aware of when looking at this?

@ChristianMurphy
Copy link
Member

Thanks for adding related docs in uPortal-Project/uportal-project.github.io#44 !

@loulou2u loulou2u self-requested a review January 24, 2023 23:06
@bjagg bjagg changed the title Feature/upse 311 Feat/upse-311: Create API to support scheduling portlet maintenance mode Jan 25, 2023
…automatically handle UTC conversion for local time
Copy link
Contributor

@loulou2u loulou2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works great! 🥇

@loulou2u loulou2u merged commit caa5a32 into uPortal-Project:master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants