Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/cache locales #2638

Merged
merged 4 commits into from Feb 8, 2023
Merged

Fix/cache locales #2638

merged 4 commits into from Feb 8, 2023

Conversation

bjagg
Copy link
Member

@bjagg bjagg commented Feb 8, 2023 •
edited

Checklist
  • the individual contributor license agreement is signed
  • commit message follows commit guidelines
  • tests are included
  • documentation is changed or added
  • new security keys and comments added to security.properties
  • new general keys and comments added to portal.properties
  • any changes that impact configuration or the database DDL added to CHANGES.md
  • message properties have been updated with new phrases
  • view conforms with WCAG 2.0 AA
Description of change

Add caching of person locales to reduce database queries.

Replaced older "Google Code" cache annotations with Spring cache annotations.

@bjagg bjagg self-assigned this Feb 8, 2023
ChristianMurphy
ChristianMurphy requested changes Feb 8, 2023
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjagg!

When you have a chance could you run ./gradlew goJF?
The formatting is failing on CI.

jgribonvald
jgribonvald approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@jgribonvald jgribonvald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and +1 with @ChristianMurphy

@bjagg
Copy link
Member Author

bjagg commented Feb 8, 2023

Resolves #1879

ChristianMurphy
ChristianMurphy approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjagg!
LGTM

@bjagg bjagg merged commit e5cde47 into uPortal-Project:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgribonvald jgribonvald jgribonvald approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@jonathanmtran jonathanmtran Awaiting requested review from jonathanmtran

@mgillian mgillian Awaiting requested review from mgillian

@loulou2u loulou2u Awaiting requested review from loulou2u

@cbeach47 cbeach47 Awaiting requested review from cbeach47

Assignees

@bjagg bjagg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjagg @jgribonvald @ChristianMurphy