This repository has been archived by the owner on May 4, 2022. It is now read-only.
Fix spacing when app navigation isn't configured #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmsibley
approved these changes
Oct 17, 2017
ChristianMurphy
approved these changes
Oct 17, 2017
components/css/buckyless/header.less
Outdated
| @@ -67,6 +54,20 @@ portal-header { | |||
| .menu-toggle.md-button { | |||
| min-width: 48px; | |||
| margin: 0; | |||
|
|
|||
| + .title-link h1 { | |||
There was a problem hiding this comment.
❓ would a general sibling selector be more robust?
components/css/buckyless/header.less
Outdated
| } | ||
|
|
||
| &.hide-gt-xs { | ||
| + .title-link h1 { |
There was a problem hiding this comment.
❓ would a general sibling selector be more robust?
|
@ChristianMurphy @davidmsibley Good catch :) |
ChristianMurphy
approved these changes
Oct 17, 2017
vertein
approved these changes
Oct 17, 2017
|
@thevoiceofzeke, I'm going to cut a release soon. This seems good to get in quick via merging? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Contributor License Agreement adherence: