This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Fixing Android-21 apk compatibility issue #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| androconf.info("Skipping null padding in StringBlock header") | ||
| header = self.readNext(buff, first_run=False) | ||
| elif header != CHUNK_STRINGPOOL_TYPE: | ||
| androconf.warning("Invalid StringBlock header") |
|
lgtm |
|
@joweeba Thanks! Great to see you visit :) |
wojked
added a commit
that referenced
this pull request
Feb 12, 2015
Fixing Android-21 apk compatibility issue
|
|
||
| if header == CHUNK_NULL_TYPE and first_run: | ||
| androconf.info("Skipping null padding in StringBlock header") | ||
| header = self.readNext(buff, first_run=False) |
There was a problem hiding this comment.
Wrong syntax it should be just readNext not self.readNext
Please send a pull request when it is fixed to androguard repo and we can close the androguard/androguard#33 issue
subho007
added a commit
to subho007/androguard
that referenced
this pull request
Feb 15, 2015
|
|
👍 awesome job BTW :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution based on: androguard/androguard#33
We might wish to back port this to the original androguard repo.