Added Spliting of Windows and version #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like OS X
|
@gjdonkers you need to update the tests as well if you want to change the parsing structure. |
doomspork
reviewed
Feb 20, 2017
regexes.yaml
Outdated
|
|
||
| - regex: '(Windows (?:NT 5\.2|NT 5\.1))' | ||
| os_replacement: 'Windows XP' | ||
| os_replacement: 'Windows' | ||
| os_v1_replacement: 'XP' |
There was a problem hiding this comment.
@gjdonkers it would be awesome to see you clean-up this PR, this is something we'd love to have. I do think the versions here are incorrect though, if you take a peek at this list you'll see for Windows XP the version is considered NT 5.1.
|
when do you plan to fix windows version and merge this? |
|
@gjdonkers This PR conflicts with #286. Is this still valid? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like OS X