Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Edge support #17

Closed
mgol opened this issue Jun 23, 2015 · 9 comments
Closed

Microsoft Edge support #17

mgol opened this issue Jun 23, 2015 · 9 comments

Comments

@mgol
Copy link

mgol commented Jun 23, 2015

uap-core now supports Microsoft Edge (it was earlier recognized as IE12, erroneously). Could you update the git submodule so that uap-php has this change as well?

@lstrojny
Copy link
Contributor

Done!

@mgol
Copy link
Author

mgol commented Jun 24, 2015

Thanks! Do you plan a new release soon?

@JustBlackBird
Copy link
Contributor

It seems that the updated version is already released as v3.4.3

@lstrojny
Copy link
Contributor

Yep, v3.4.3 is released and has the changes

@mgol
Copy link
Author

mgol commented Jun 24, 2015

Ahh, thanks again then. :)

@Abhinav1217
Copy link

Hi,
Sorry to open it again but I updated my system to windows 10, and Now on edge browser,
print $result->ua->family; outputs as Chrome instead of Edge.

This is the output I am getting on your example.

========================================
Edge:
========================================

ua-parser-php Test

ua-parser-php is the PHP library for the ua-parser project. Please use this page to test your browser. ua-parser-php was developed to help support my Detector project.
  ua->family: Chrome
  ua->major: 42
  ua->minor: 0
  ua->patch: 2311
  ua->toString: Chrome 42.0.2311
  ua->toVersionString: 42.0.2311
  os->family: Windows
  os->major: 
  os->minor: 
  os->patch: 
  os->patch_minor: 
  os->toString: Windows
  os->toVersionString: 
  device->family: Other
  toFullString: Chrome 42.0.2311/Windows
  uaOriginal: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/12.10240

As a temp fix on my website, I am searching for "Edge" using regex in $result->originalUserAgent;
But It would be nice to get Family as Edge.

@mgol
Copy link
Author

mgol commented Aug 24, 2015

@Abhinav1217 it seems you have an outdated version, it should work in 3.4.3 as stated above.

@Abhinav1217
Copy link

I used ua-parser/uap-php in composer init automated install.

It added "ua-parser/uap-php": "^3.4" in composer.json

how do i get the version of the installed library?

@Abhinav1217
Copy link

I re downloaded from composer specifically for 3.4.3 It is still detecting Edge as chrome.
I even checked http://uaparser.dmolsen.com/. Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants