Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In master, the parser class is responsible for reading a path from disk, parsing it from yaml to ruby, converting all of the patterns into actual ruby regexes, and then finally matching those regexes/patterns to return browser family/version, operating system family/version, and device.
In this branch, the parser is responsible only for matching patterns. I used a file pattern loader which handles the read file, yaml parse, regex conversion and responds to call. The parser then takes an instance of anything that responds to call and returns a hash of patterns/regexes.
I added examples for basic usage and custom pattern loader usage. Also updated all readme and such. Should be good to go.