Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables have nans instead of empty cells #22

Closed
wwarriner opened this issue Feb 8, 2022 · 3 comments · Fixed by #51
Closed

Tables have nans instead of empty cells #22

wwarriner opened this issue Feb 8, 2022 · 3 comments · Fixed by #51
Assignees
Labels
fix: bug Something isn't working

Comments

@wwarriner
Copy link
Contributor

The table importer fills blanks with "nan". Doesn't appear to be an obvious solution, and the plugin has no config for it. We may need to investigate deeper.

@mdefende
Copy link
Member

mdefende commented Feb 9, 2022

The actual script for creating the table can be found at https://github.com/timvink/mkdocs-table-reader-plugin/blob/master/mkdocs_table_reader_plugin/plugin.py. The location where the table is converted to Markdown text and pasted into the source .md file is at the bottom of the linked script (line 208+). It doesn't seem like it would be too difficult to fork the repo and add in a snippet that replaces any nan text with 3 spaces (or whatever would make the table readable, not sure.

This is potentially something to hack on a Tuesday when we aren't quite as busy

@wwarriner wwarriner added the fix: bug Something isn't working label Feb 9, 2022
@wwarriner wwarriner self-assigned this Feb 9, 2022
@wwarriner
Copy link
Contributor Author

Looks like its a typical pandas issue with nans appearing. It's part of read_csv. I think we can solve this purely by modifying the jinja code in the markdown file. Instead of:

{{ read_csv( file ) }}

We do

{{ read_csv( file, keep_default_na=False ) }}

@wwarriner
Copy link
Contributor Author

Yep worked perfectly. Putting together pull request.

wwarriner added a commit to wwarriner/uabrc.github.io that referenced this issue Feb 9, 2022
This was referenced Feb 9, 2022
jgordini added a commit to jgordini/uabrc.github.io that referenced this issue Oct 24, 2023
…ctions

Add instructions for entering/updating AWS IAM credentials in Globus for LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants