Reverted orientation checking fix #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This caused layout issues where if you swiped left/right on the real device, you wouldn't be able to see the other views. - UIDevice.currentDevice().orientation.isPortrait checks the physical orientation of your device, which may not be the same as your application's orientation. Please refer to https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIDevice_Class/#//apple_ref/occ/instp/UIDevice/orientation
fahlout
added a commit
that referenced
this pull request
Jul 2, 2015
Reverted orientation checking fix
|
UIDevice.currentDevice().orientation ignore Deployment Info > Device Orientation better if it's use UIApplication.sharedApplication().statusBarOrientation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
real device, you wouldn't be able to see the other views.
physical orientation of your device, which may not be the same as
your application's orientation. Please refer to
https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIDevice_Class/#//apple_ref/occ/instp/UIDevice/orientation