Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataverse logo when posting to Facebook is Harvard's, not ours #71

Closed
pbinkley opened this issue Dec 3, 2018 · 4 comments
Closed

Dataverse logo when posting to Facebook is Harvard's, not ours #71

pbinkley opened this issue Dec 3, 2018 · 4 comments

Comments

@pbinkley
Copy link
Member

pbinkley commented Dec 3, 2018

Here's what a Facebook posting of a dataset looks like:

image

The image is from src/main/webapp/resources/images/dataverseproject.png. It seems to be linked here in our html:

<link type="image/png" rel="image_src" href="/javax.faces.resource/images/dataverseproject.png.xhtml" />

which is hardcoded in the template.

We should replace it with an appropriate UAlberta logo.

@piyapongch
Copy link
Member

This issue will be discussed in the next Dataverse migration meeting, @johnhuck @henryzhang87 @piyapongch.

@piyapongch
Copy link
Member

@johnhuck, Can you provide me the logo you want to replace? I will update the application. Then, we need to update the war file in Henry's upgrade scripts? Thanks,

@johnhuck
Copy link

johnhuck commented Jun 9, 2020

@piyapongch I'm not sure exactly what the image should be. In Peter's example, it's not actually the Harvard logo, but the Dataverse project logo. Do we want one that says U of A, or UAL Dataverse or what. Do we have an image we already use for something like ERA? I'll follow up with James. I'd like his input on these questions.

@johnhuck
Copy link

James Doiron and I discussed this issue today and concluded that we will not take any action on this issue for these reasons: the logo is the Dataverse logo, not Harvard's; and this is not a high-priority issue at the present time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants