Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Restart Button for containers #137

Merged
merged 13 commits into from
Jun 9, 2024
Merged

Add Restart Button for containers #137

merged 13 commits into from
Jun 9, 2024

Conversation

briodan
Copy link
Contributor

@briodan briodan commented Nov 27, 2023

I found it handy to have a restart button for containers that I can push from a dashboard.

@briodan
Copy link
Contributor Author

briodan commented Jun 8, 2024

moved the button to asyncio based on the work in PR #140

@ualex73
Copy link
Owner

ualex73 commented Jun 8, 2024

I am happy to merge this one, but can you put the default too disable for this button feature? I think most users will not prefer it, if even more entities are added to HA.

So change:
vol.Optional(CONF_BUTTONENABLED, default=True): vol.Any(
to:
vol.Optional(CONF_BUTTONENABLED, default=False): vol.Any(

@briodan
Copy link
Contributor Author

briodan commented Jun 8, 2024

my use case is to have an auto entities card that auto-populates with the reboot buttons for all containers, that way as i add/remove containers the reboot button automatically shows up and i don't have to manage it.

maybe this can be added as a configuration option, so the button is disabled by default but can be enabled by default if the user choses it, but that might be to big of a code change. Can probably achieve that with an automation of sorts.

i'll update the code shortly so this can be merged in and can look at the rest as a separate PR

disable reboot button by default
@ualex73 ualex73 merged commit 420ad24 into ualex73:master Jun 9, 2024
2 checks passed
@ualex73
Copy link
Owner

ualex73 commented Jun 9, 2024

I just merged the change in the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants