Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
sumeetjain opened this issue Mar 3, 2015 · 0 comments
Open

Feedback #1

sumeetjain opened this issue Mar 3, 2015 · 0 comments

Comments

@sumeetjain
Copy link

👍

But here are some things you can think about for taking it to the next level:


https://github.com/uanwar88/2015-02-16-message-board/blob/master/models/user.rb#L2

https://github.com/uanwar88/2015-02-16-message-board/blob/master/models/modules.rb#L13

Makes sense. But is there a way to infer the name of the table, so you don't have to set it manually?


https://github.com/uanwar88/2015-02-16-message-board/blob/master/models/user.rb#L16

So if I don't provide a username, what happens? If you needed to add additional validations later, how would you do that?


https://github.com/uanwar88/2015-02-16-message-board/blob/master/models/board.rb#L15-L19

Return value could be better; also documentation.


https://github.com/uanwar88/2015-02-16-message-board/blob/master/controllers/thread.rb#L3

What would it take for you to be able to run @thread.posts instead?

And could something similar be done for https://github.com/uanwar88/2015-02-16-message-board/blob/master/controllers/thread.rb#L4 ?


https://github.com/uanwar88/2015-02-16-message-board/blob/master/controllers/thread.rb#L11

What does this actually check for? Code comment would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant