Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions: define ordering as implementation dependent #79

Merged
merged 1 commit into from Sep 25, 2023

Conversation

bluca
Copy link
Member

@bluca bluca commented Sep 23, 2023

sd-sysext uses versioned ordering, while ExtensionImages= respects the specified order

Copy link
Member

@keszybz keszybz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, do we really want to do this? Shouldn't we just adjust the implementations to use the same rules?

@bluca
Copy link
Member Author

bluca commented Sep 25, 2023

Not sure, to me it makes sense that it you specify a specific order because the use case allows it, it is respected, but in other cases you have autodiscovery

@keszybz
Copy link
Member

keszybz commented Sep 25, 2023

Then I'd prefer to say that. "Implementation-defined" ~= "undefined". I think it's much better to say "The default order is …, but implementations may allow a different order to be specified."

sd-sysext uses versioned ordering, while ExtensionImages= respects the specified order,
so set a default but let implementations override it
@bluca
Copy link
Member Author

bluca commented Sep 25, 2023

Then I'd prefer to say that. "Implementation-defined" ~= "undefined". I think it's much better to say "The default order is …, but implementations may allow a different order to be specified."

ok, done

Copy link
Member

@keszybz keszybz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think this is crystal clear now.

@keszybz keszybz merged commit 74a9648 into uapi-group:main Sep 25, 2023
1 check passed
@bluca bluca deleted the sysext_order branch September 25, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants