-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix external link menu management item #740
Conversation
@@ -1,7 +1,7 @@ | |||
<template> | |||
<div | |||
:class="{ 'vs-sidebar-item-active': getActive }" | |||
class="vs-sidebar--item" | |||
class="vs-sidebar--item " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unwanted space ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, it was a typo and I've returned to the original position
@@ -25,6 +25,15 @@ | |||
/> | |||
</a> | |||
<!-- for route link --> | |||
<template v-else> | |||
<a v-if="url.substring(0, 4) == 'http'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about https ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without any https conditions the condition function produces the same results for http or https
No description provided.