New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve doc for examples of controlling reading/writing #73
Conversation
…lass docstring, after finding that ReadTheDocs omits the __init__ docstring
ping @t-hackwood |
Thanks @neilflood - I think that looks better. I wonder if we should also mention that pixel values from outside an image will be 'faked' with the nodata value for that image (for eg. UNION)? And what do we do if there is no nodata (fail)? |
Good points, thanks @gillins I expanded the docstring for setFootprintType, so this information is not just in the examples doco. I had to look up about the "no null value" case, it is in imagereader.py, line 541, readBlockWithMargin(). The logic is really there for the normal margin handling anyway, but the UNION case effectively makes huge margins on some inputs. |
Thanks @neilflood looks good to me! |
Thanks for the updated examples @neilflood @gillins! They look great, much easier to understand! |
OK, great, thank you. I will merge this :-) And thanks for bringing this to our attention. |
Also some minor changes to docstrings in support of this.