Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve doc for examples of controlling reading/writing #73

Merged
merged 11 commits into from Nov 27, 2023
Merged

Improve doc for examples of controlling reading/writing #73

merged 11 commits into from Nov 27, 2023

Conversation

neilflood
Copy link
Member

Also some minor changes to docstrings in support of this.

@gillins
Copy link
Member

gillins commented Nov 23, 2023

ping @t-hackwood

@gillins
Copy link
Member

gillins commented Nov 23, 2023

Thanks @neilflood - I think that looks better. I wonder if we should also mention that pixel values from outside an image will be 'faked' with the nodata value for that image (for eg. UNION)? And what do we do if there is no nodata (fail)?

@neilflood
Copy link
Member Author

neilflood commented Nov 23, 2023

Good points, thanks @gillins

I expanded the docstring for setFootprintType, so this information is not just in the examples doco. I had to look up about the "no null value" case, it is in imagereader.py, line 541, readBlockWithMargin(). The logic is really there for the normal margin handling anyway, but the UNION case effectively makes huge margins on some inputs.

@gillins
Copy link
Member

gillins commented Nov 23, 2023

Thanks @neilflood looks good to me!

@t-hackwood
Copy link

Thanks for the updated examples @neilflood @gillins! They look great, much easier to understand!

@neilflood
Copy link
Member Author

OK, great, thank you. I will merge this :-)

And thanks for bringing this to our attention.

@neilflood neilflood merged commit 200a0f5 into ubarsc:master Nov 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants