Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1 #19

Closed
Doooooris opened this issue Feb 11, 2019 · 2 comments
Closed

Milestone 1 #19

Doooooris opened this issue Feb 11, 2019 · 2 comments

Comments

@Doooooris
Copy link

Very good job! Clear explanation and documentation of your package!

  • test_locate_na.py: Consider some extreme cases, like all input data is N/A
  • test_replace_na.py: Need to test output calculation is correct for mean, median, etc... Additionally, need to test the output, for example, make sure output is not equal to input. Moreover, need to test if the input is making sense.
  • test_summary.py: Need to test input.
@tungpatrick
Copy link
Collaborator

Thank you for your feedback!

@heathervant
Copy link
Collaborator

Thanks ! I will test the input in the code using
if isinstance(data, pd.DataFrame) == False:
raise NotImplementedError("Input should be a pandas dataframe. Use pd.DataFrame(data)")

and add a test to the test script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants