Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from using install_dependencies to rosdep #94

Closed
garethellis0 opened this issue Feb 17, 2017 · 2 comments · Fixed by #195
Closed

Move away from using install_dependencies to rosdep #94

garethellis0 opened this issue Feb 17, 2017 · 2 comments · Fixed by #195

Comments

@garethellis0
Copy link
Collaborator

garethellis0 commented Feb 17, 2017

Right now we're using a script (install_dependencies)to manually install all dependencies, but CI uses a different (and much better system) where it finds all the requirements from the package.xml files (fairly sure it's rosdep, or something like that anyhow). We should look at what CI is doing (script is located here) and change install_dependencies to just use the same commands that CI does (although it should be kept separate from getting_started to make it easier for people to update all their dependencies after they've setup the repo for the first time

@garethellis0
Copy link
Collaborator Author

After looking into it some more, this should just be a matter of replacing the call to install_dependencies.sh from get_started.sh to our rosdep install command from travis. Alternatively, we may want to keep this command as it's own script (in install_dependencies.sh, so we can have people update dependencies without having to re-run the entire setup script. The travis command in questions is rosdep install -y -q -n --from-paths . --ignore-src --rosdistro kinetic. @ValRat - thoughts?

@garethellis0
Copy link
Collaborator Author

Probably want something more like this actually:

#!/bin/bash

# The current directory
CURR_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

# Installs all required dependencies to build this repo
rosdep install --from-paths $CURR_DIR --ignore-src --rosdistro=ROSDISTRO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant