Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How will Galactus changing from Classy base theme to starterkit affect this theme? #27

Open
darko-hrgovic opened this issue Feb 3, 2023 · 1 comment

Comments

@darko-hrgovic
Copy link

James, Joel and I discussed the deprecation of Classy and need to rebuild Galactus with starterkit and remove the Classy dependency.

How will this affect this theme?

Does it also need to be rebuilt with Galactus as the starterkit?

@occupant
Copy link
Member

occupant commented Feb 4, 2023

@darko-hrgovic I'm still exploring this a bit, but from what I see so far:

  • child themes can remain unchanged (other than core_version_requirement and fixing deprecated code in any custom hooks) for Drupal 10 - the changes in the parent theme won't require any changes to the child theme
  • classy is NOT a valid starterkit theme, but this can be bypassed by 'hacking core' and adding starterkit: true to the classy .info file. This then allows classy to generate a base theme via the php core/scripts/drupal generate-theme --starterkit classy [my_new_theme]. The one thing I'm not 100% clear on is whether classy has the required base elements from its base theme, stable. Nested dolls... This needs review / testing

If we can rely on the output of the script above (ie. it's complete and includes all assets), the transition is fairly simple. We add any templates that are not in the theme already, update the hooks (there's one additional), add image / css assets and update the libraries. At that point Galactus can be a completely decoupled base theme without any additional core themes it will need to rely on.

Anyway, that's what I see so far. The proof will be in the pudding (whatever that means)....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants