Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with multiple ubcpi xblocks in same unit #153

Merged
merged 1 commit into from Jan 18, 2019

Conversation

kitsook
Copy link
Contributor

@kitsook kitsook commented Jan 18, 2019

  • fix the issue that if there are multiple ubcpi in the same unit,
    clicking on an answer text will jump to the top of the page and the
    answer is not selected

  • fix the issue that when the subsection has multiple units with ubcpi,
    clicking on submit button will jump to the top of the page

  • fix the issue that when the student finished Step 1 and switch to
    another unit and back, persisted data is not displayed and Step 1 is
    displayed again

Closes #152
Closes #33

- fix the issue that if there are multiple ubcpi in the same unit,
clicking on an answer text will jump to the top of the page and the
answer is not selected

- fix the issue that when the subsection has multiple units with ubcpi,
clicking on submit button will jump to the top of the page

- fix the issue that when the student finished Step 1 and switch to
another unit and back, persisted data is not displayed and Step 1 is
dispalyed again
@kitsook kitsook requested a review from xcompass January 18, 2019 00:05
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 96.646% when pulling 47061b6 on #152-fix-multi-ubcpi-in-same-unit into ff69bbb on master.

@xcompass xcompass merged commit bf99237 into master Jan 18, 2019
@xcompass xcompass deleted the #152-fix-multi-ubcpi-in-same-unit branch January 18, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants