Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UBCPI to support Python 3 #173

Merged
merged 2 commits into from Jun 17, 2020
Merged

Update UBCPI to support Python 3 #173

merged 2 commits into from Jun 17, 2020

Conversation

kitsook
Copy link
Contributor

@kitsook kitsook commented May 19, 2020

- revise README file
- update version in setup.py
- cherry-picked changes submitted by PR #167 on the old UI for py3 migration
- upgrade Coverage.py for it to work with python 3.8
@kitsook kitsook requested a review from xcompass May 19, 2020 22:12
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 95.61% when pulling 3cb4e13 on py3_updates into c40c514 on master.

@toxinu
Copy link

toxinu commented Jun 15, 2020

That's a great news! Thanks @kitsook :)

@xcompass xcompass merged commit e828d73 into master Jun 17, 2020
@xcompass xcompass deleted the py3_updates branch June 17, 2020 01:13
@pomegranited
Copy link

Thank you so much for this @kitsook !

Do you know whether this update also means that this XBlock works with open edx's Juniper django 2.2?

@kitsook
Copy link
Contributor Author

kitsook commented Jun 18, 2020

Thank you so much for this @kitsook !

Do you know whether this update also means that this XBlock works with open edx's Juniper django 2.2?

That was the goal. But this PR was created before the official Juniper devstack release. I will do some testing on juniper.1 when time permits.

@pomegranited
Copy link

Thank you @kitsook ! Let me know if we can help? e.g. OpenCraft can create a Juniper sandbox with this XBlock installed, and you can run your tests there.

@pomegranited
Copy link

Hi @kitsook -- do you plan to create a new tag for this juniper-compatible release?

@kitsook
Copy link
Contributor Author

kitsook commented Aug 17, 2020

Once we tested it with Juniper and investigated a reported issue related to translation, we will tag a version and submit a PR for upstream edX to pick it up.

kitsook added a commit to kitsook/configuration that referenced this pull request Sep 10, 2020
- included changes to work with Python 3
  ubc/ubcpi#167
  ubc/ubcpi#173

- revised UI
@kitsook
Copy link
Contributor Author

kitsook commented Sep 10, 2020

pull and merged latest translation. tagged version 1.0.0.

a PR has been submitted to edx to pull this version
https://github.com/edx/configuration/pull/6002

coryleeio pushed a commit to openedx-unsupported/configuration that referenced this pull request Oct 15, 2020
- included changes to work with Python 3
  ubc/ubcpi#167
  ubc/ubcpi#173

- revised UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants