Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PI to request changes to resource allocation attributes #294

Closed
knikolla opened this issue May 5, 2021 · 2 comments
Closed

Allow PI to request changes to resource allocation attributes #294

knikolla opened this issue May 5, 2021 · 2 comments

Comments

@knikolla
Copy link
Contributor

knikolla commented May 5, 2021

As a PI, I would like the possibility of requesting a change to resource allocation attributes after a resource allocation has been created and approved. This request would require approval from administrators before being executed.

Resource allocation attributes are used to express quotas/limitations of a resource allocation on a resource, and in a cloud environment where some resource allocations can be very long lived, should be allowed to scale up as usage and requirements grow.

@dsajdak
Copy link
Contributor

dsajdak commented May 26, 2021

Possibly related to or in place of #287

@dsajdak
Copy link
Contributor

dsajdak commented Jun 9, 2021

This is a high level diagram of what we'd want the process to look like. We want to allow the PI/manager to make change requests on SOME allocation attributes, as well as the end date, and possible other things. This sketches out two potential ways to accomplish this:

allocation_change_update

This is a rough idea of what option 2, described in above diagram, could look like:
allocationdetail

We'll need to think about the various resource types and what attribute types they may have as well as what allocation attribute types might be available for those resource types to ensure we test all possible scenarios. As described in the text of the first diagram, we'll need a way to define that an attribute can have a change request and if not, it is not possible to be modified in this process. That needs to be configurable on the attribute type because admins have the ability to add new attribute types:

allocationattributes

brisco17 added a commit to brisco17/coldfront that referenced this issue Aug 6, 2021
…en checked this property allows a 'request change' button to appear next to the corresponding attribute on its Allocation Detail page. This button will be used to link the user to a new form which will allow them to request changes to be made to the attribute (form still in progress).
brisco17 added a commit to brisco17/coldfront that referenced this issue Aug 16, 2021
… will be used to allow PI's to request an extension on an allocation's End Date if checked in the admin portal. The 'Request Change' button on an Allocation Detail page has now been moved to the top of the page (and only one will appear for all desired changes). Fixed routing issue for the 'Request Allocation Attribute Change' form. Form in progress
brisco17 added a commit to brisco17/coldfront that referenced this issue Oct 29, 2021
brisco17 added a commit to brisco17/coldfront that referenced this issue Oct 31, 2021
brisco17 added a commit to brisco17/coldfront that referenced this issue Nov 2, 2021
… the 'is_changable' field is explicitly added (not having this was causing issues for existing ColdFront installations)
brisco17 added a commit to brisco17/coldfront that referenced this issue Nov 2, 2021
…risco17/coldfront into ubccr#294-change-allocation-attributes
brisco17 added a commit to brisco17/coldfront that referenced this issue Nov 5, 2021
…'Allocation Detail' page now only appears if the allocation's 'is_changeable' field is set to true. A user can also only access the 'Allocation Change' form if the allocation has an acceptable status (almost everything besides 'Expired')
brisco17 added a commit to brisco17/coldfront that referenced this issue Nov 11, 2021
…de whether or not to allow allocation change requests by default and to customize the list of days users can request allocation extensions
brisco17 added a commit to brisco17/coldfront that referenced this issue Nov 16, 2021
…Form data is missing or has been tampered with'). Also balanced form tag in allocation_change.html to fix invalid HTML error
brisco17 added a commit to brisco17/coldfront that referenced this issue Nov 17, 2021
…nstances, can get the allocation change status choices loaded into their application automatically
brisco17 added a commit to brisco17/coldfront that referenced this issue Nov 17, 2021
…l page template to include the new 'is changeable' field
brisco17 added a commit to brisco17/coldfront that referenced this issue Nov 23, 2021
brisco17 added a commit to brisco17/coldfront that referenced this issue Dec 1, 2021
… post notes when a change is approved/denied
brisco17 added a commit to brisco17/coldfront that referenced this issue Dec 20, 2021
brisco17 added a commit to brisco17/coldfront that referenced this issue Dec 22, 2021
brisco17 added a commit to brisco17/coldfront that referenced this issue Dec 22, 2021
aebruno added a commit that referenced this issue Dec 22, 2021
@dsajdak dsajdak closed this as completed Jan 11, 2022
@dsajdak dsajdak added this to Completed in Version 1.1.0 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Version 1.1.0
Completed
Development

No branches or pull requests

2 participants