Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIRS is not an attribute but a key #351

Merged
merged 4 commits into from
Jan 12, 2022
Merged

DIRS is not an attribute but a key #351

merged 4 commits into from
Jan 12, 2022

Conversation

lebonez
Copy link
Contributor

@lebonez lebonez commented Jan 12, 2022

change .DIRS to a key since this failed as below:
TEMPLATES[0].DIRS.insert(0, SITE_TEMPLATES)
AttributeError: 'dict' object has no attribute 'DIRS'

@lebonez
DIRS is not an attribute but a key
a9e9d74 
change .DIRS to a key since this failed as below:
TEMPLATES[0].DIRS.insert(0, SITE_TEMPLATES)
AttributeError: 'dict' object has no attribute 'DIRS'
@lebonez
LDAP user search Timeout is too short to be not configurable. Also no…
4306d72 
…t everyone uses ssl so make it configurable
@aebruno aebruno self-requested a review January 12, 2022 20:56
aebruno
aebruno requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@aebruno aebruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lebonez Thanks for the fixes! Just spotted a very minor change with the defaults to better match those from ldap3.

coldfront/config/plugins/ldap_user_search.py Outdated Show resolved Hide resolved
coldfront/plugins/ldap_user_search/utils.py Outdated Show resolved Hide resolved
@aebruno aebruno merged commit 68b2623 into ubccr:master Jan 12, 2022
@aebruno
Copy link
Member

aebruno commented Jan 12, 2022

Thanks!

@dsajdak dsajdak added this to Completed in Version 1.1.0 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aebruno aebruno aebruno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Version 1.1.0
Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lebonez @aebruno