Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default log file permissions #1333

Merged
merged 2 commits into from Jun 11, 2020
Merged

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented Jun 9, 2020

Description

Change the default file and directory permissions for log files created by the CCR\Log class. Also updates the class constructor to allow these permissions to be changed.

Note that log files created directly by the Log class are not changed.

Motivation and Context

https://app.asana.com/0/342819846538629/1178746552707810/f

Tests performed

Tested manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added enhancement Enhancement of the functionality of an existing feature Category:General General labels Jun 9, 2020
@jtpalmer jtpalmer added this to the 9.0.0 milestone Jun 9, 2020
@jtpalmer jtpalmer merged commit f611529 into ubccr:xdmod9.0 Jun 11, 2020
@jtpalmer jtpalmer deleted the log-mode branch June 11, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:General General enhancement Enhancement of the functionality of an existing feature
Projects
None yet
2 participants