Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent errors when previewing a report #26

Merged
merged 1 commit into from Jan 17, 2017

Conversation

jtpalmer
Copy link
Contributor

Description

Adds additional checks when an attempt is made to preview a report.

Motivation and Context

Currently, when a user attempts to preview a report that has not been saved they will be presented with what appears to be a report filled with errors. This change prevents that behavior and instead presents a friendlier message that is consistent with those displayed when an attempt is made to either download or email an unsaved report.

Tests performed

Created a report and attempted to preview it without first saving it. Observed new error message. Saved and then successfully previewed the report. Altered the report and again attempted to preview before saving. Observed new error message.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A report cannot be previewed until after it has been saved.
@jtpalmer jtpalmer added the bug Bugfixes label Jan 13, 2017
@jtpalmer jtpalmer added this to the v6.6.0 milestone Jan 13, 2017
@jtpalmer jtpalmer merged commit ee14545 into ubccr:xdmod6.6 Jan 17, 2017
@jtpalmer jtpalmer deleted the report-builder-fix branch January 18, 2017 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes
Projects
None yet
2 participants