Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle proper escaping of backslashes to preserve source data #53

Merged
merged 1 commit into from Feb 15, 2017

Conversation

smgallo
Copy link
Contributor

@smgallo smgallo commented Feb 14, 2017

Handle proper escaping of backslashes to preserve source data

Description

Source data containing backslashes must be properly escaped to preserve the backslashes.

Motivation and Context

See #52

Tests performed

Tested using SimpleDatabaseIngestor with the following source data and verified that backslashes were not preserved prior to but were after the patch.

'\', '\\', '\\n\\'

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@smgallo smgallo added the bug Bugfixes label Feb 14, 2017
@smgallo smgallo added this to the v6.6.0 milestone Feb 14, 2017
@smgallo smgallo merged commit a542830 into ubccr:xdmod6.6 Feb 15, 2017
@smgallo smgallo deleted the etl/escape-slashes branch February 15, 2017 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes
Projects
None yet
2 participants