Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused database table column (moddb.Users.parent_user_id) #54

Merged
merged 1 commit into from Feb 16, 2017

Conversation

jtpalmer
Copy link
Contributor

Description

Adds migration to remove the parent_user_id column from the Users table in the moddb database.

Also bumps version numbers and adds migration boilerplate. This could be moved to a separate PR, but is needed for testing purposes.

Motivation and Context

This column is not used and causes problems with MySQL's strict sql_modes since it is NOT NULL and does not have a default value and no value was being set.

Tests performed

Manually tested migration:

  • Installed Open XDMoD 6.5.0
  • Upgraded to a build of this branch
  • Ran xdmod-upgrade
  • Observed that the column was removed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Remove `moddb`.`Users`.`parent_user_id` which is not used and causes
problems since it is `NOT NULL` and does not have a default value.
@jtpalmer jtpalmer added the bug Bugfixes label Feb 16, 2017
@jtpalmer jtpalmer added this to the v6.6.0 milestone Feb 16, 2017
@jtpalmer jtpalmer merged commit 8e6dcbf into ubccr:xdmod6.6 Feb 16, 2017
@jtpalmer jtpalmer deleted the remove-user-parent-user-id branch February 16, 2017 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes
Projects
None yet
2 participants