CR Comments

.travis.yml

@@ -67,11 +67,6 @@ install:
   - export CGO_LDFLAGS="$CGO_LDFLAGS -L`pwd` -lrocksdb"
   - export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:`pwd`"
 
-before_script:
-  - export CHERAMI_PACKAGES=`go list ./... | grep -ve vendor | grep -ve test | sed "s#github.com/uber/cherami-server#.#"` 
-  - go tool vet -all -printfuncs=Info,Infof,Debug,Debugf,Warn,Warnf,Panic,Panicf $CHERAMI_PACKAGES
-  - gofmt -l $CHERAMI_PACKAGES
-
 script:
   - EMBEDROCKSDB=0 make cover_ci
 

Makefile

@@ -50,7 +50,7 @@ INTEG_TEST_DIRS := $(filter $(INTEG_TEST_ROOT)%,$(ALL_TEST_DIRS))
 #   Packages are specified as import paths.
 GOCOVERPKG_ARG := -coverpkg="$(PROJECT_ROOT)/common/...,$(PROJECT_ROOT)/services/...,$(PROJECT_ROOT)/clients/..."
 
-test: bins
+test: lint bins
 	@for dir in $(ALL_TEST_DIRS); do \
 		go test $(EMBED) "$$dir" $(TEST_NO_RACE_ARG) $(shell glide nv); \
 	done;
@@ -122,3 +122,7 @@ clean:
 	rm -f cherami-server cherami-replicator-server cherami-cli cherami-admin cherami-replicator-tool cherami-cassandra-tool
 	rm -Rf vendor/*
 	rm -Rf $(BUILD)
+
+lint:
+	gofmt -l $(ALL_SRC)
+	go tool vet -all -printfuncs=Info,Infof,Debug,Debugf,Warn,Warnf,Panic,Panicf $(ALL_TEST_DIRS)