This repository has been archived by the owner on Feb 23, 2021. It is now read-only.
Get *.js indentation from .editorconfig file #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Semver is not optional. if you make a breaking change you got 1.0. In fact, the fact that you have any project that is <1.0 is silly, all modules should start at v1 or v2 out of the gate. If you have some sort of emotional attachment to version "1.0" then forget that. Communicating with your users is always more important. |
| @@ -1,39 +1,12 @@ | |||
| 'use strict'; | |||
| var detectIndent = require('detect-indent'); | |||
| require('array.prototype.find'); | |||
There was a problem hiding this comment.
dont do that please. there is a nice var find = require('find') module.
|
Please ship with a default editorconfig in the rc folder. |
|
Got it. Todo:
|
| if (parseErr) { | ||
| return callback(parseErr); | ||
| } | ||
| var jsRules = parsed.find(function getJsRuleSet(ruleset) { |
There was a problem hiding this comment.
You can just do [].filter() or [].some() i think...
|
Let me know if this is okay now. |
|
Since I'm going to cut a 1.0.0 for this, I'm also resolving these issues: |
|
Resolving #76 |
This was referenced Jan 17, 2015
|
lgtm. |
andrewdeandrade
pushed a commit
that referenced
this pull request
Jan 17, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #39
Once this is accepted, I'll cut 0.5.0 (breaking api change since you need an .editorconfig file). Let me know if I should make editorconfig optional. My gut is no since .editorconfig does a lot to help multiple people working on the same project.
cc: @Raynos