This repository has been archived by the owner on May 4, 2021. It is now read-only.
Log time to do fs sync on layer create #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our usage we are seeing occasional very large gaps between the final node in the build running and the subsequent layer commit. We suspect that fs sync before the layer diff is calculated is the cause and would like to get confirmation on this.
|
|
ahmagdy
approved these changes
Nov 4, 2020
sema
approved these changes
Nov 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our usage we are seeing occasional very large gaps between the final node in the build running and completion of the subsequent layer commit. We suspect that fs sync before the layer diff is calculated is the cause and would like to get confirmation on this.