Add more tests for error cases

uber-archive · Jun 28, 2015 · 25c5704 · 25c5704
1 parent 8aa053c
commit 25c5704
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/src/test/java/com/uber/jenkins/phabricator/conduit/ArcanistClientTest.java b/src/test/java/com/uber/jenkins/phabricator/conduit/ArcanistClientTest.java
@@ -21,6 +21,7 @@
 package com.uber.jenkins.phabricator.conduit;
 
 import hudson.Launcher;
+import net.sf.json.JSONException;
 import net.sf.json.JSONObject;
 import org.junit.Rule;
 import org.junit.Test;
@@ -64,6 +65,19 @@ public void testParseConduit() throws Exception {
         assertEquals(result.getString("hello"), "world");
     }
 
+    @Test(expected = ArcanistUsageException.class)
+    public void testNonZeroExitCode() throws Exception {
+        ArcanistClient client = new ArcanistClient("false", "", emptyParams, null);
+
+        client.parseConduit(getLauncher().launch(), System.err);
+    }
+
+    @Test(expected = JSONException.class)
+    public void testNonJsonOutput() throws Exception {
+        ArcanistClient client = new ArcanistClient("echo", "not-json", emptyParams, null);
+        client.parseConduit(getLauncher().launch(), System.err);
+    }
+
     private Launcher getLauncher() {
         return j.createLocalLauncher();
     }