Handle base commit not found error

[ChaitanyaPramod]

Sometimes, diffs are made against commits which haven't been pushed up to remote yet. The build fails in this case, but no notification of result is made to Harbormaster.

[workspace] $ /var/lib/arc/arcanist/bin/arc call-conduit differential.querydiffs ********
Applying patch for differential
[workspace] $ git reset --hard 1a9049ef170d7351ca18ba164bfe8e73bcf4fdcd
fatal: Could not parse object '1a9049ef170d7351ca18ba164bfe8e73bcf4fdcd'.
Got non-zero exit code resetting to base commit 1a9049ef170d7351ca18ba164bfe8e73bcf4fdcd: 128
[workspace] $ git clean -fd -f
[workspace] $ git submodule update --init --recursive
[workspace] $ /var/lib/arc/arcanist/bin/arc patch --nobranch --diff 3955 --nocommit ********


    This diff is against commit 1a9049ef170d7351ca18ba164bfe8e73bcf4fdcd, but
    the commit is nowhere in the working copy. Try to apply it against the
    current working copy state? (cabbdf90274bcef598ae45a47c1ceb0c7ba2b1ec)
    [Y/n] Exception
The program is attempting to read user input, but stdin is being piped from some other source (not a TTY).
(Run with `--trace` for a full exception trace.)
49[arcanist] Error applying arc patch; got non-zero exit code 1

The plugin should handle this case and either

• report build failure on Phabricator (Harbormaster)
• allow applying the patch on some git reference (like master branch) through a configuration

[ascandella]

Yes, this is definitely a bug. I will look at this after getting #60 merged, since there's some pretty heavy refactoring going on.

[ascandella]

As soon as the associated PR is merged I will cut a new release.

[ascandella]

This is now released in 1.7 of the plugin. Note that conduit credentials have moved into the "Credentials" plugin so you'll need to follow the instructions at https://github.com/uber/phabricator-jenkins-plugin#configuration

[mindheist]

So, what should we expect after this change ? Should I see a notification on Phabricator about the build failure ?

[ascandella]

It should set the build status to failed, just like if the tests failed.