Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated HttpClient to a version that's not removed #357

Merged
merged 1 commit into from Jan 24, 2023

Conversation

betterphp
Copy link
Contributor

@betterphp betterphp commented Jan 5, 2023

Fixes issue #356

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2023

CLA assistant check
All committers have signed the CLA.

@betterphp betterphp changed the title Updated HttpClient to a version that's not removed #356 Updated HttpClient to a version that's not removed fixes #356 Jan 5, 2023
@betterphp betterphp changed the title Updated HttpClient to a version that's not removed fixes #356 Updated HttpClient to a version that's not removed Jan 5, 2023
@betterphp betterphp marked this pull request as ready for review January 5, 2023 17:40
@jonathanbaker7
Copy link
Contributor

This PR has been escalated into the Uber OSPO, and we will try to put together a team to review it so that you can go back to operational status. I can't tell you when, yet, because it's just come in today, but we will try to get updated soon.

@betterphp
Copy link
Contributor Author

Cool thanks :)

Copy link
Contributor

@jonathanbaker7 jonathanbaker7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert with Phabricator, but I am a Java developer and have experience with Jenkins. I don't see any problems with these changes, so I'm going to approve them to move this back into support.

@jonathanbaker7 jonathanbaker7 merged commit 2bf9116 into uber-archive:master Jan 24, 2023
@betterphp
Copy link
Contributor Author

Great thanks, we've been running a version of the plugin with these changes for about 3 weeks and haven't had any problems with it.

Would it be possible to do a 2.1.6 release to get this in to the jenkins plugin repo?

@TheWrongGuy
Copy link

Just wanted to report that your fix works perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants