Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PhabricatorNotifier comment builder #48

Merged
merged 3 commits into from
Jul 20, 2015
Merged

Refactor PhabricatorNotifier comment builder #48

merged 3 commits into from
Jul 20, 2015

Commits on Jul 20, 2015

  1. Refactor PhabricatorNotifier comment builder 

    Instead of having one heaping class that's responsible for a bunch of
business logic, breaking out the comment building and code coverage
comparison into a self-contained class that is easier to test and understand.

Future refactors will break down the Notifier even further, but this is
one atomic piece of work that can go in.

Additionally, fixed a bug in the TestUtils default coverage data, which
was off by 100x for cobertura results (since cobertura the plugin
returns them as floats from 0-1)
    @ascandella
    ascandella committed Jul 20, 2015
    Configuration menu
    Copy the full SHA
    345ef8b View commit details
    Browse the repository at this point in the history

  2. Simplify hasCoverageAvailable

    @ascandella
    ascandella committed Jul 20, 2015
    Configuration menu
    Copy the full SHA
    34626f4 View commit details
    Browse the repository at this point in the history

  3. Simplify even more

    @ascandella
    ascandella committed Jul 20, 2015
    Configuration menu
    Copy the full SHA
    1d8c629 View commit details
    Browse the repository at this point in the history