Initial version

[mlmorg]

cc @cain-uber

[Raynos]

lgtm.

[cain-wang]

Hi Matt,

Awesome! Thanks for setting up the ground work.
I had some prototype code running, shall I post a code review and we could
discuss it?

Thanks,

Cain

On Sun, Dec 21, 2014 at 6:08 PM, Matt Morgan notifications@github.com
wrote:

cc @cain-uber https://github.com/cain-uber

You can merge this Pull Request by running

git pull https://github.com/uber/r-dom dev/initial

Or view, comment on, or merge it at:

#1
Commit Summary

• Get basic tag working
• Add a bunch of tests and get them working
• Add a bunch of tests for components
• Add more tests
• Change name of file
• Add more key property tests
• Change test name
• More test changes
• Get ready for shipping
• Add readme

File Changes

• M .gitignore https://github.com/uber/r-dom/pull/1/files#diff-0
  (3)
• A .travis.yml https://github.com/uber/r-dom/pull/1/files#diff-1
  (6)
• A CHANGELOG.md https://github.com/uber/r-dom/pull/1/files#diff-2
  (5)
• A LICENSE https://github.com/uber/r-dom/pull/1/files#diff-3 (22)
• M README.md https://github.com/uber/r-dom/pull/1/files#diff-4
  (41)
• M index.js https://github.com/uber/r-dom/pull/1/files#diff-5
  (40)
• M package.json https://github.com/uber/r-dom/pull/1/files#diff-6
  (31)
• A test/fixtures/create-component.js
  https://github.com/uber/r-dom/pull/1/files#diff-7 (22)
• A test/fixtures/render-types.js
  https://github.com/uber/r-dom/pull/1/files#diff-8 (50)
• M test/index.js https://github.com/uber/r-dom/pull/1/files#diff-9
  (66)

Patch Links:

• https://github.com/uber/r-dom/pull/1.patch
• https://github.com/uber/r-dom/pull/1.diff

—
Reply to this email directly or view it on GitHub
#1.

[mlmorg]

Do you want me to merge this first?

[cain-wang]

Oh, I just found out somehow github rejected my review comments earlier ..
I'll just post it here.

I noticed we are having the children passed in as an array into r(),
React.createElement() just assumes whatever follows the attribute config
are child elements, I think that provides a cleaner syntax.

Thanks,

Cain

[cain-wang]

Also, when we use the JS API to create React element, we don't need to wrap the returned block with (), right?

Yay, github finally lets me post comments :)