This repository has been archived by the owner on Feb 23, 2021. It is now read-only.
Adding ability to output numbers #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just wrap in a string? |
|
That works for a literal string, but if your dealing with number in a var or JSON you'd have to call obj.number.toString() or do some other form of type coersion. I don't think you should have to do that If we didn't want to support number types, it fails silently. At the minimum we should have a console.warn message about invalid types. |
|
Ok. Can we add a test for it? Thanks! |
mlmorg
added a commit
that referenced
this pull request
Apr 22, 2015
Adding ability to output numbers
|
Published as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.