uintptr test: Fix overflow on architectures with 32-bit pointers #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #99 The current uintptr test assumes that pointers are 64-bit, so the test fails to compile on architectures with 32-bit pointers. Instead, cast -1 to uintptr, which matches math.MaxUint64 on 64-bit architectures, and math.MaxUint32 on 32-bit architectures. Verified by using GOARCH=386
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 181 181
=========================================
Hits 181 181 Continue to review full report at Codecov.
|
abhinav
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99
The current uintptr test assumes that pointers are 64-bit, so the test
fails to compile on architectures with 32-bit pointers. Instead, cast
-1 to uintptr, which matches math.MaxUint64 on 64-bit architectures, and
math.MaxUint32 on 32-bit architectures.
Verified by using GOARCH=386