Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Pin versions with go.mod, similar to server (#1060)
The versioning strategy unfortunately is leaking some dependencies, and codegen isn't reproducible any more. This update mimics how github.com/uber/cadence does dependencies, and is more "normal" for go modules anyway. Implications of these changes include: - Some build and runtime dependencies have changed versions in relatively minor ways. This mostly brings them more in line with the versions used to generate code. - Users may end up downloading more dependencies (e.g. staticcheck), maybe not, depending on how Go decides to handle non-buildable transitive dependencies. They've always _intended_ to prune them implicitly, but I do not know if that is happening yet. - Users should not be _constrained_ by these dependencies, however, as they have no actual import, and do not appear in their go.mod files. Upgrading or downgrading tools in a test project worked and did not require `replace` directives. And since this does away with the "X commits / versions behind current" notification: I've added `make deps` (and `make deps-all`), which works the same way as in uber/cadence/pull/4000. Hopefully it's understandable enough to modify easily.
- Loading branch information
Showing
5 changed files
with
99 additions
and
284 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.