add workflow id reuse policy to child workflow

uber-go · Jan 9, 2018 · c1f85e4 · c1f85e4
1 parent 6e69f89
commit c1f85e4
Show file tree

Hide file tree

Showing 6 changed files with 122 additions and 41 deletions.
diff --git a/.gen/go/shared/idl.go b/.gen/go/shared/idl.go
diff --git a/.gen/go/shared/types.go b/.gen/go/shared/types.go
diff --git a/idl/github.com/uber/cadence/shared.thrift b/idl/github.com/uber/cadence/shared.thrift
@@ -306,6 +306,7 @@ struct StartChildWorkflowExecutionDecisionAttributes {
   70: optional i32 taskStartToCloseTimeoutSeconds
   80: optional ChildPolicy childPolicy
   90: optional binary control
+  100: optional WorkflowIdReusePolicy workflowIdReusePolicy
 }
 
 struct Decision {
@@ -538,6 +539,7 @@ struct StartChildWorkflowExecutionInitiatedEventAttributes {
   80:  optional ChildPolicy childPolicy
   90:  optional binary control
   100: optional i64 (js.type = "Long") decisionTaskCompletedEventId
+  110: optional WorkflowIdReusePolicy workflowIdReusePolicy
 }
 
 struct StartChildWorkflowExecutionFailedEventAttributes {

diff --git a/internal/internal_event_handlers.go b/internal/internal_event_handlers.go
@@ -223,6 +223,7 @@ func (wc *workflowEnvironmentImpl) ExecuteChildWorkflow(
 	attributes.Input = options.input
 	attributes.WorkflowType = workflowTypePtr(*options.workflowType)
 	attributes.ChildPolicy = options.childPolicy.toThriftChildPolicyPtr()
+	attributes.WorkflowIdReusePolicy = options.workflowIDReusePolicy.toThriftPtr()
 
 	decision := wc.decisionsHelper.startChildWorkflowExecution(attributes)
 	decision.setData(&scheduledChildWorkflow{

diff --git a/internal/internal_workflow.go b/internal/internal_workflow.go
@@ -164,6 +164,7 @@ type (
 		waitForCancellation                 bool
 		signalChannels                      map[string]Channel
 		queryHandlers                       map[string]func([]byte) ([]byte, error)
+		workflowIDReusePolicy               WorkflowIDReusePolicy
 	}
 
 	// decodeFutureImpl

diff --git a/internal/workflow.go b/internal/workflow.go
@@ -162,6 +162,10 @@ type (
 		// as: completed/failed/timedout/terminated/canceled)
 		// Optional: default false
 		WaitForCancellation bool
+
+		// WorkflowIDReusePolicy - Whether server allow reuse of workflow ID, can be useful
+		// for dedup logic if set to WorkflowIdReusePolicyRejectDuplicate
+		WorkflowIDReusePolicy WorkflowIDReusePolicy
 	}
 
 	// ChildWorkflowPolicy defines child workflow behavior when parent workflow is terminated.
@@ -495,6 +499,7 @@ func WithChildWorkflowOptions(ctx Context, cwo ChildWorkflowOptions) Context {
 	wfOptions.taskStartToCloseTimeoutSeconds = common.Int32Ptr(int32(cwo.TaskStartToCloseTimeout.Seconds()))
 	wfOptions.childPolicy = cwo.ChildPolicy
 	wfOptions.waitForCancellation = cwo.WaitForCancellation
+	wfOptions.workflowIDReusePolicy = cwo.WorkflowIDReusePolicy
 
 	return ctx1
 }