Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable query timeout of 20 seconds #1038

Merged
merged 3 commits into from Nov 25, 2020
Merged

Enable query timeout of 20 seconds #1038

merged 3 commits into from Nov 25, 2020

Conversation

andrewjdawson2016
Copy link
Contributor

No description provided.

@andrewjdawson2016 andrewjdawson2016 changed the title Query timeout Enable query timeout of 20 seconds Nov 25, 2020
yycptt
yycptt reviewed Nov 25, 2020
View reviewed changes
internal/internal_utils.go
@@ -99,8 +101,17 @@ func chanTimeout(timeout time.Duration) func(builder *contextBuilder) {
}
}

// newChannelContext - Get a rpc channel context for query
func newChannelContextForQuery(ctx context.Context, options ...func(builder *contextBuilder)) (context.Context, context.CancelFunc, []yarpc.CallOption) {
Copy link
Contributor

@yycptt yycptt Nov 25, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this new function used somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gosh 🤦 ty

@coveralls
Copy link

Pull Request Test Coverage Report for Build 420f41e4-f466-4036-81bf-3ff933142c6e

  • 9 of 10 (90.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 74.963%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/internal_utils.go 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
internal/internal_utils.go 1 88.24%
internal/internal_task_pollers.go 2 75.34%
Totals Coverage Status
Change from base Build dcc3cfe5-fdae-4cb9-b906-fff122c8f2d5: -0.02%
Covered Lines: 9587
Relevant Lines: 12789
💛 - Coveralls

@andrewjdawson2016 andrewjdawson2016 merged commit c641ff7 into master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@just-at-uber just-at-uber just-at-uber left review comments

@yycptt yycptt yycptt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewjdawson2016 @coveralls @yycptt @just-at-uber