Compatibility layer fix #1120
Merged
Compatibility layer fix #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build da3507f7-9f1a-4c20-93b2-b04f07f57e99
💛 - Coveralls |
yux0
approved these changes
Aug 17, 2021
vytautas-karpavicius
added a commit
that referenced
this pull request
Aug 18, 2021
* Add integration test for domain update * Fix protoUpdateDomainRequest for compatibility layer
vytautas-karpavicius
added a commit
that referenced
this pull request
Aug 23, 2021
* Add integration test for domain update * Fix protoUpdateDomainRequest for compatibility layer
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed
protoUpdateDomainRequestin compatibility layer.Why?
Previously it was not handling intermediate nil structures.
How did you test it?
Added additional integration test to cover domain update operation.
Potential risks