Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JitterStart support to client #1178

Merged
merged 2 commits into from Jul 16, 2022
Merged

Add JitterStart support to client #1178

merged 2 commits into from Jul 16, 2022

Conversation

ZackLK
Copy link
Contributor

@ZackLK ZackLK commented Jul 14, 2022

Added JitterStart parameter to StartWorkflow and ContinueAsNew

Verified by modifying the cron cadence sample and testing locally.

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@ZackLK ZackLK requested review from demirkayaender and a team July 14, 2022 21:33
@ZackLK ZackLK removed the request for review from demirkayaender July 15, 2022 23:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 0182049e-7c8c-44b7-a267-36f770a30d97

  • 9 of 17 (52.94%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 63.918%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/compatibility/proto/history.go 0 1 0.0%
internal/compatibility/proto/request.go 1 2 50.0%
internal/compatibility/thrift/decision.go 0 1 0.0%
internal/compatibility/thrift/request.go 0 1 0.0%
internal/internal_workflow_client.go 6 10 60.0%
Files with Coverage Reduction New Missed Lines %
internal/compatibility/proto/history.go 1 0%
internal/compatibility/thrift/request.go 1 0%
Totals Coverage Status
Change from base Build 0181b24f-c812-4399-b98d-d8f07b90e9dd: -0.01%
Covered Lines: 12455
Relevant Lines: 19486
💛 - Coveralls

@ZackLK ZackLK merged commit e66e2d4 into master Jul 16, 2022
@ZackLK ZackLK deleted the zack branch July 16, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ZackLK @CLAassistant @coveralls @davidporter-id-au