Fix flaky test #1201
Merged
Fix flaky test #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groxx
reviewed
Dec 2, 2022
test/integration_test.go
Outdated
Comment on lines
593
to
594
| var val interface{} | ||
| return wfRun.Get(ctx, &val) |
There was a problem hiding this comment.
Suggested change
| var val interface{} | |
| return wfRun.Get(ctx, &val) | |
| return wfRun.Get(ctx, nil) |
Groxx
reviewed
Dec 2, 2022
test/integration_test.go
Outdated
Comment on lines
422
to
423
| resp, err := ts.libClient.DescribeWorkflowExecution(context.Background(), childWorkflowID, "") | ||
| ts.NoError(err) |
There was a problem hiding this comment.
probably not necessary any more? I don't think GetWorkflow needs a runid anyway...
Groxx
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixing flaky integration test since master build was failing. Test was flaky because it was testing that child workflow gets terminated when parent workflow finishes. The test was running into race condition.
Why?
How did you test it?
pipeline run.
Potential risks