Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #181

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Update README.md #181

merged 1 commit into from
Jul 10, 2017

Conversation

molteanu
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

coveralls commented Jul 10, 2017

Coverage Status

Coverage remained the same at 92.086% when pulling 997874a on readme_update into 246b216 on master.

@@ -23,9 +23,9 @@ See [samples](https://github.com/samarabbas/cadence-samples) to get started

Activity is the implementation of a particular task in the business logic.

Activities are implemented as functions. Data can be passed directly to an activity via function parameters. The parameters can be either basic types or structs, with the only requirement being that the parameters need to be serializable. Even though it is not required, we recommand that the first parameter of an activity function is of type `context.Context`, in order to allow the activity to interact with other framework methods. The function must return an `error` value, and can optionally return a result value. The result value can be either a basic type or a struct with the only requirement being that the it is serializable.
Activities are implemented as functions. Data can be passed directly to an activity via function parameters. The parameters can be either basic types or structs, with the only requirement being that the parameters need to be serializable. Even though it is not required, we recommand that the first parameter of an activity function is of type `context.Context`, in order to allow the activity to interact with other framework methods. The function must return an `error` value, and can optionally return a result value. The result value can be either a basic type or a struct with the only requirement being that it is serializable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The function must return an error value, and can optionally return a result value."

For activities we allow them to have three possible return types.

  • Void (No return values, like quick loggers, where the caller doesn't care)
  • error (Just error)
  • (result, error) - result can be any serializable value.

@molteanu molteanu merged commit 855bbc8 into master Jul 10, 2017
@molteanu molteanu deleted the readme_update branch October 4, 2017 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants