Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deterministic check for searchable change version #889

Merged
merged 4 commits into from Nov 26, 2019
Merged

Fix deterministic check for searchable change version #889

merged 4 commits into from Nov 26, 2019

Conversation

vancexu
Copy link
Contributor

@vancexu vancexu commented Nov 26, 2019 •
edited

This PR includes:

  1. Fix non-deterministic error for searchable change version.
  2. Fix first upsertSearchAttributes contains redundant attrs from following upsert calls.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 478

  • 18 of 23 (78.26%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 75.338%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/internal_task_handlers.go 12 17 70.59%
Totals Coverage Status
Change from base Build 473: 0.01%
Covered Lines: 8761
Relevant Lines: 11629
💛 - Coveralls

@vancexu vancexu merged commit 13c05f6 into master Nov 26, 2019
@vancexu vancexu deleted the fixd branch November 26, 2019 22:37
@vancexu vancexu mentioned this pull request Nov 27, 2019
Closed
vancexu added a commit that referenced this pull request Dec 2, 2019
@vancexu
Fix deterministic check for searchable change version (#889)
5a70ce8 
This PR includes:
Fix non-deterministic error for searchable change version.
Fix first upsertSearchAttributes contains redundant attrs from following upsert calls.
@dependabot-preview dependabot-preview bot mentioned this pull request Feb 24, 2020
Closed
sevein pushed a commit to sevein/cadence-client that referenced this pull request Mar 6, 2020
@vancexu @sevein
Fix deterministic check for searchable change version (uber-go#889)
200d84b 
This PR includes:
Fix non-deterministic error for searchable change version.
Fix first upsertSearchAttributes contains redundant attrs from following upsert calls.
@longquanzheng longquanzheng mentioned this pull request Aug 15, 2021
Closed
@longquanzheng longquanzheng mentioned this pull request Nov 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meiliang86 meiliang86 meiliang86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vancexu @coveralls @meiliang86