Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up CI #6

Closed
abhinav opened this issue Oct 19, 2022 · 1 comment
Closed

Set up CI #6

abhinav opened this issue Oct 19, 2022 · 1 comment
Milestone
Open Source Prep

Comments

@abhinav
Copy link
Collaborator

abhinav commented Oct 19, 2022

We need to set up CI for the repository.
We can model it after Fx or Zap's setup.
It should include the following checks:

  • run tests with race detection
  • verify generated code is up to date
  • post coverage data to codecov.io (probably opt-out generated files?)

Eventually, since cff has a binary component, we'll likely also want to set up goreleaser to publish binaries to GitHub (which will likely also affect install instructions), but that's all open sourcing.
@abhinav abhinav added this to the Open Source Prep milestone Oct 19, 2022
This was referenced Oct 19, 2022
Closed
Closed
abhinav added a commit that referenced this issue Oct 19, 2022
@abhinav
ci: Add build and test
6e9dfc0 
Sets up a minimal CI job that does two things:

- verifies that all generated code is  up to date
- builds cff and runs all tests

Refs #6
abhinav added a commit that referenced this issue Oct 19, 2022
@abhinav
ci: Add build and test
951d53c 
Sets up a minimal CI job that does two things:

- verifies that all generated code is  up to date
- builds cff and runs all tests with coverage tracking

Depends on #16
Refs #6
abhinav added a commit that referenced this issue Oct 19, 2022
@abhinav
ci: Add build and test
7ceee09 
Sets up a minimal CI job that does two things:

- verifies that all generated code is  up to date
- builds cff and runs all tests with coverage tracking

Depends on #16
Refs #6
abhinav added a commit that referenced this issue Oct 20, 2022
@abhinav
ci: Add build and test (#12)
d134418 
Sets up a minimal CI job that does two things:

- verifies that all generated code is  up to date
- builds cff and runs all tests with coverage tracking

Depends on #16
Refs #6
@abhinav
Copy link
Collaborator Author

abhinav commented Oct 20, 2022

Done with #12

@abhinav abhinav closed this as completed Oct 20, 2022
sywhang added a commit that referenced this issue Oct 26, 2022
@sywhang
Delete magic_clean_test
dc321a8 
With #6 we can depend on `make generate` to verify that the
generated code is up-to-date.
@sywhang sywhang mentioned this issue Oct 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
Open Source Prep
Development

No branches or pull requests
1 participant
@abhinav